Vulkan suboptimal swapchain fixes #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RipleyTom
reviewed
Aug 16, 2019
…swapchain vkAcquireNextImageKHR can also return VK_SUBOPTIMAL_KHR and is non-fatal. However, it's a good idea to still recreate the swap chain later to maintain optimal presentation paths after temporary occlusion.
Plagman
force-pushed
the
vulkan_suboptimal_swapchain
branch
from
6fabaa1
to
a59275d
Compare
kd-11
approved these changes
Aug 16, 2019
|
Thanks for looking at it. This triggers for radv on an X11 Linux desktop on
my side, if Freesync is enabled (compositing off). The rendering would die
if I was playing and got a notification, or if alt-tabbed away from the
window. With this patch applied locally I played for an hour, had the game
in the background, etc, without seeing the problem.
…On Fri, Aug 16, 2019, 09:32 kd-11 ***@***.***> wrote:
***@***.**** approved this pull request.
Just out of curiosity: Is there any driver on desktop that returns this
code? I tested for a long time and never could make it happen.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6355?email_source=notifications&email_token=AAEBMCRTZTOCG75UKTXOUY3QE3JAHA5CNFSM4IMEMIG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCB2CZNY#pullrequestreview-276049079>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEBMCV26UAWYYBDKIMNPYLQE3JAHANCNFSM4IMEMIGQ>
.
|
|
That explains it then, I don't have a freesync monitor so I never saw it. I'll merge as a hotfix. |
|
Apparently it isn't Freesync specific, just transitioning between pageflipping and not (and pageflipping is required for Freesync). So you wouldn't ever see it on a desktop with compositing enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.